Skip to content

Rename Parser.Lookahead functions from is* to at* #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

natikgadzhi
Copy link
Contributor

Motivation

Closes #2001. Following up on #1996, renaming Parser.Lookahead function for consistency.

The change is that Parser.Lookahead.isStartOfGetSetAccessor is now atStartOfGetSetAccessor.

@ahoppen, am I missing something? Thought there would be more.

@natikgadzhi natikgadzhi requested a review from ahoppen as a code owner August 4, 2023 22:48
@ahoppen
Copy link
Member

ahoppen commented Aug 4, 2023

There are more is functions in Lookahead and I think all of them should be renamed. isStartOfGetSetAccessor was just an example.

@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented Aug 4, 2023

That's what I thought — wait a sec, let me look ahead at them more thoroughly.

UPD: Done.

@natikgadzhi natikgadzhi force-pushed the lookahead/rename-is-to-at branch from 55d5129 to 638a0f0 Compare August 4, 2023 23:02
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you 👍🏽

@ahoppen
Copy link
Member

ahoppen commented Aug 5, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge August 5, 2023 03:50
@ahoppen
Copy link
Member

ahoppen commented Aug 9, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 777520e into swiftlang:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Lookahead.is* function to at*
2 participants